chore: add todos on switching to newer duckdb list_concat() syntax #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't do this because |
|
Hm, sorry for the fast close. I think we can keep the TODO about using |
cpcloud
requested changes
Nov 6, 2024
| @@ -349,7 +349,14 @@ def visit_UnwrapJSONBoolean(self, op, *, arg): | |||
| ) | |||
|
|
|||
| def visit_ArrayConcat(self, op, *, arg): | |||
| # TODO: duckdb 1.1.3 was the first release to support list_concat(a,b,c,d,...) | |||
There was a problem hiding this comment.
We can't do this because list_concat will always follow the postgres array_cat behavior, which is NOT to propagate NULLs.
There was a problem hiding this comment.
Oops, yes that's correct. I will fix these up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want these changes to eventually make it in