Use prepended length for bit-packed hybrid bool columns #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johan13
force-pushed
the
fix-packed-hybrid-bools
branch
from
eb6b9d2 to
f187eb8
Compare
platypii
approved these changes
Feb 19, 2025
| @@ -22,7 +22,7 @@ export function bitWidth(value) { | |||
| */ | |||
| export function readRleBitPackedHybrid(reader, width, length, output) { | |||
| if (!length) { | |||
| // length = reader.view.getUint32(reader.offset, true) | |||
| length = reader.view.getUint32(reader.offset, true) | |||
| @@ -0,0 +1,17 @@ | |||
| [ | |||
| [1], | |||
There was a problem hiding this comment.
It seems like this should be true not 1 for this file since the column has type BOOLEAN. But that is a separate issue, not a blocker for getting this fix in.
|
Published fix to npm in version 1.8.3. Thanks again @johan13! |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyparquet v1.8.2 fails to read boolean columns that use the RLE/Bit-Packing Hybrid encoding. It either reads incorrect data or crashes with a
RangeError: Offset is outside the bounds of the DataViewerror.It seems that this is caused by Hyparquet not reading the prepended length of the RLE data page. See the table at the end of the RLE = 3 section here: https://parquet.apache.org/docs/file-format/data-pages/encodings/