Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support endpoints that don't support range requests in asyncBufferFromUrl #57

Merged
merged 3 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,38 @@ export async function asyncBufferFromUrl({ url, byteLength, requestInit }) {
if (!url) throw new Error('missing url')
// byte length from HEAD request
byteLength ||= await byteLengthFromUrl(url, requestInit)

/**
* A promise for the whole buffer, if range requests are not supported.
* @type {Promise<ArrayBuffer>|undefined}
*/
let buffer = undefined
const init = requestInit || {}

return {
byteLength,
async slice(start, end) {
// fetch byte range from url
if (buffer) {
return buffer.then(buffer => buffer.slice(start, end))
}

const headers = new Headers(init.headers)
const endStr = end === undefined ? '' : end - 1
headers.set('Range', `bytes=${start}-${endStr}`)

const res = await fetch(url, { ...init, headers })
if (!res.ok || !res.body) throw new Error(`fetch failed ${res.status}`)
return res.arrayBuffer()

if (res.status === 200) {
// Endpoint does not support range requests and returned the whole object
buffer = res.arrayBuffer()
return buffer.then(buffer => buffer.slice(start, end))
} else if (res.status === 206) {
// The endpoint supports range requests and sent us the requested range
return res.arrayBuffer()
} else {
throw new Error(`fetch received unexpected status code ${res.status}`)
}
},
}
}
Expand Down
41 changes: 41 additions & 0 deletions test/utils.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ describe('asyncBufferFromUrl', () => {
global.fetch = vi.fn().mockResolvedValue({
ok: true,
body: {},
status: 206,
arrayBuffer: () => Promise.resolve(mockArrayBuffer),
})

Expand All @@ -131,6 +132,7 @@ describe('asyncBufferFromUrl', () => {
global.fetch = vi.fn().mockResolvedValue({
ok: true,
body: {},
status: 206,
arrayBuffer: () => Promise.resolve(mockArrayBuffer),
})

Expand Down Expand Up @@ -191,6 +193,7 @@ describe('asyncBufferFromUrl', () => {
return Promise.resolve({
ok: true,
body: {},
status: 206,
arrayBuffer: () => Promise.resolve(mockArrayBuffer),
})
})
Expand All @@ -203,4 +206,42 @@ describe('asyncBufferFromUrl', () => {

await expect(withHeaders.slice(0, 10)).rejects.toThrow('fetch failed 404')
})

describe('when range requests are unsupported', () => {
it('creates an AsyncBuffer with the correct byte length', async () => {
const mockArrayBuffer = new ArrayBuffer(1024)
global.fetch = vi.fn().mockResolvedValue({
ok: true,
status: 200,
body: {},
arrayBuffer: () => Promise.resolve(mockArrayBuffer),
})

const buffer = await asyncBufferFromUrl({ url: 'https://example.com', byteLength: 1024 })
const chunk = await buffer.slice(0, 100)

expect(fetch).toHaveBeenCalledWith('https://example.com', {
headers: new Headers({ Range: 'bytes=0-99' }),
})

expect(chunk.byteLength).toBe(100)
})

it('does not make multiple requests for multiple slices', async () => {
const mockArrayBuffer = new ArrayBuffer(1024)
global.fetch = vi.fn().mockResolvedValue({
ok: true,
status: 200,
body: {},
arrayBuffer: () => Promise.resolve(mockArrayBuffer),
})

const buffer = await asyncBufferFromUrl({ url: 'https://example.com', byteLength: 1024 })

await buffer.slice(0, 100)
await buffer.slice(550, 600)

expect(fetch).toBeCalledTimes(1)
})
})
})
Loading