-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation part I #436
Open
RAVMN
wants to merge
62
commits into
hummingbird-me:develop
Choose a base branch
from
RAVMN:patch-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Translation part I #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial changes to test
test file
uses React Native Languages to get system language
temporal fix for i18n
PLayed with "QuickUpdateScreen", tested variable use, but has to get the type of media translated when episodeOrChapter is in use... |
No HTML escaping in this library :c |
translated seasons in search. Categories aren't working as the displayed tearms are the same as the one used to retrieve the list, have to separate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling translation with i18n-js and RNLanguage (I know is an old version, but it is targeted against the React version in use)
Manually linked RNLangauge because if Cocoapods install it, it also downloads an old version of React and I can't get it to compile.
ConsoleLog strings aren't included in the translation as they will just be shown to developers.
I hope I haven't break anything
Here is a list of the files that are to be translated in the future (WIP):
*screens/
-Auth/AuthScreen.js
-Auth/RecoveryScreen.js
-Feed/components/...
-Feed/feedStreams.js
-Intro/IntroScreen.js
-Intro/RegistrationScreen.js
-Library/LybraryScreen/component.js
-Library/LybrarySearch/component.js
-Notifications/NotificationHeader/component.js
-Onboarding/Aozora/CreateAccountScreen.js
-Onboarding/Aozora/SelectAccountScreen.js
-Onboarding/Aozora/WelcomeScreen.js
-Onboarding/common/FavoriteScreen.js
-Onboarding/common/ManageLibrary.js
-Onboarding/common/RateScreen/screen.js
-Onboarding/Kitsu/ImportDetail.js
-Onboarding/Kitsu/ImportLibrary.js
-Profiles/...
-QuickUpdateScreen/QuickUpdate.js
-QuickUpdateScreen/QuickUpdateCard/component.js
-QuickUpdateScreen/QuickUpdateEditor/component.js
-Search/...
-Sidebar/...
*store/
-media/actions.js
-onboarding/actions.js
-onboarding/favoriteCategories.js
-profile/actions.js
-user/actions.js