Improve modular documentation #35737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super nice, thanks for this really detailed doc! I recently reworked the modular transformers doc a bit as a part of the larger docs refactor, and would love to include this in it. I'll give it a more detailed review on Tuesday! 🤗 |
|
Sure! Let me know how you want to proceed, i.e. if I should merge this one before or not 😉 |
ArthurZucker
approved these changes
Jan 20, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title! Modular has changed quite a bit and is more and more important, so it is important to have a nice and thorough documentation about it so that people can understand it quickly and use it efficiently.
In the end, it makes all of our lives better in the review process! 🤪