-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch moonshine #35731
Merged
Merged
Patch moonshine #35731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eustlb
requested review from
stevhliu,
Rocketknight1 and
ArthurZucker
as code owners
January 16, 2025 16:38
ArthurZucker
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As discussed, let's mention why this is needed in the patch!
ArthurZucker
pushed a commit
that referenced
this pull request
Jan 20, 2025
* udpate expected logits for T4 runners * update doc * correct order of the args for better readability * remove generate wrap * convert modular
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
attention_mask
is provided) in generate's wrap by simply removing the generate wrapJustification concerning the last point: it's been discussed that handling per-batch-idx max_lengths is something that is going to be added directly to
generate
(see #35676). In the future,Moonshine
's processor will returnmax_length=[val_1, ... ,val_n]
that will directly be intended to be passed asmax_length
generate's parameter. For this reason,max_length
should be computed outside generate and therefore the current wrap is not necessary! The wrap was intended to reduce hallucinations that are an edge case but impact evaluation on a test set compare to original codebase. Model cards and recommanded usage will be updated with the correct usage: