-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for MQTT subentries with notify platform support #37473
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the MQTT integration has been updated. The changes include the removal of the section detailing the steps to remove the MQTT integration, replaced by a concise statement indicating that MQTT devices and entities can now be set up through MQTT discovery or manual addition via YAML or subentries. New sections have been added to explain configuring MQTT components via subentries and manual configuration for MQTT Notify entities, with examples provided for clarity. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant UI as MQTT Integration UI
participant DOC as Documentation
U->>UI: Navigate to MQTT Integration Settings
UI-->>U: Display current settings and options
U->>UI: Select "Add Device via Subentries"
UI-->>U: Present device configuration form
U->>UI: Submit new device details
UI-->>U: Confirm device addition
sequenceDiagram
participant U as User
participant YAML as configuration.yaml
participant M as MQTT Integration Service
U->>YAML: Update file with MQTT Notify entity details
U->>M: Trigger configuration reload/restart
M-->>U: Activate updated MQTT configuration
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
source/_integrations/mqtt.markdown (2)
1394-1396
: Notify Entity Manual Configuration Note
The documentation now includes a note that manual configuration support has been added for MQTT Notify entities (with other platforms to follow). Consider rephrasing for clarity, for example:“Manual configuration support for MQTT Notify entities has been added. Support for other platforms will follow.”
137-137
: Remove Extra Blank Line
Static analysis indicates that there are multiple consecutive blank lines here. Please remove the extra blank line to adhere to markdown style guidelines and improve readability.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
137-137: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/mqtt.markdown
(4 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/mqtt.markdown
137-137: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
🪛 LanguageTool
source/_integrations/mqtt.markdown
[grammar] ~184-~184: The modal verb ‘can’ requires the verb’s base form.
Context: ...e reconfigured. Additional entities can added, or an entity can bve removed from the ...
(MD_BASEFORM)
🔇 Additional comments (2)
source/_integrations/mqtt.markdown (2)
54-54
: New MQTT Devices Setup Note
The added sentence now informs users that MQTT devices and entities can be set up either via MQTT discovery or manually through YAML/subentries. This aligns with the PR’s objective by highlighting the new support for MQTT subentries.
122-127
: Introduction of the MQTT Subentries Section
This new section clearly introduces the configuration of MQTT components via subentries and currently lists the Notify integration. This is a good first step toward supporting subentries for MQTT devices—in line with the PR’s goals.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce! Thank you, @jbouwh 👍
Proposed change
Add initial support for MQTT subentries.
The initial support allows to set up a MQTT Device with Notify entities.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit