Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for new bosch alarm integration #37458

Open
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

sanjay900
Copy link

@sanjay900 sanjay900 commented Feb 14, 2025

Proposed change

Add documentation for a new bosch alarm integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

Summary by CodeRabbit

  • Documentation
    • Added comprehensive documentation for the Bosch Alarm integration within Home Assistant.
    • The guide details supported alarm panel models and outlines functionalities such as alarm control, including arm/disarm commands and state reporting.
    • It provides configuration instructions and highlights security considerations, including passcode requirements and local pin options.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 7be4e93
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67afc191834cea0008c57d4c
😎 Deploy Preview https://deploy-preview-37458--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Feb 14, 2025

📝 Walkthrough

Walkthrough

This pull request introduces a new documentation file for the Bosch Alarm integration. The document outlines the integration’s configuration details, including its title, description, supported Bosch alarm panel models, and the Alarm Control Panel entity. It details the authentication process via the Mode 2 API, security considerations, and standard removal procedures.

Changes

File Change Summary
source/_integrations/bosch_alarm.markdown Added new documentation for the Bosch Alarm integration, detailing configuration parameters, supported panel models, entity types, API authentication, and removal instructions.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f214ba and 7be4e93.

📒 Files selected for processing (1)
  • source/_integrations/bosch_alarm.markdown (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_integrations/bosch_alarm.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (3)
source/_integrations/bosch_alarm.markdown (3)

25-25: Simplify wording for better readability.

Consider simplifying "in order to" to just "to" for better readability.

-The **Bosch Alarm Panel** {% term integration %} allows you to connect your [Bosch Alarm Panel](https://www.boschsecurity.com) to Home Assistant in order to control and monitor your Bosch Alarm Panel.
+The **Bosch Alarm Panel** {% term integration %} allows you to connect your [Bosch Alarm Panel](https://www.boschsecurity.com) to Home Assistant to control and monitor your Bosch Alarm Panel.
🧰 Tools
🪛 LanguageTool

[style] ~25-~25: Consider a shorter alternative to avoid wordiness.
Context: ...ww.boschsecurity.com) to Home Assistant in order to control and monitor your Bosch Alarm Pa...

(IN_ORDER_TO_PREMIUM)


52-52: Add missing period after "etc".

In American English, the abbreviation "etc" should include a period.

-This entity reports state (_disarmed_, _armed_away_, etc), and contains custom attributes _ready_to_arm_ (_no_|_home_|_away_), and a _faulted_points_ counter.
+This entity reports state (_disarmed_, _armed_away_, etc.), and contains custom attributes _ready_to_arm_ (_no_|_home_|_away_), and a _faulted_points_ counter.
🧰 Tools
🪛 LanguageTool

[style] ~52-~52: In American English, abbreviations like “etc.” require a period.
Context: ...eports state (disarmed, armed_away, etc), and contains custom attributes _ready...

(ETC_PERIOD)


95-95: Remove unnecessary hyphen.

Since "regularly" is an adverb ending in 'ly', the hyphen in "regularly-configured" is unnecessary.

-⚠️ Since the _Mode 2_ automation user has "superuser" privileges, it bypasses the regularly-configured alarm pin: you will _not_ be prompted for a _User_ code when arming/disaming through the integration.
+⚠️ Since the _Mode 2_ automation user has "superuser" privileges, it bypasses the regularly configured alarm pin: you will _not_ be prompted for a _User_ code when arming/disaming through the integration.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~95-~95: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ..."superuser" privileges, it bypasses the regularly-configured alarm pin: you will not be prompted f...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0ce231 and bae712c.

📒 Files selected for processing (1)
  • source/_integrations/bosch_alarm.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/bosch_alarm.markdown

[style] ~25-~25: Consider a shorter alternative to avoid wordiness.
Context: ...ww.boschsecurity.com) to Home Assistant in order to control and monitor your Bosch Alarm Pa...

(IN_ORDER_TO_PREMIUM)


[style] ~52-~52: In American English, abbreviations like “etc.” require a period.
Context: ...eports state (disarmed, armed_away, etc), and contains custom attributes _ready...

(ETC_PERIOD)


[uncategorized] ~95-~95: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ..."superuser" privileges, it bypasses the regularly-configured alarm pin: you will not be prompted f...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

🪛 GitHub Actions: home-assistant.io Test
source/_integrations/bosch_alarm.markdown

[warning] 31-31: Unexpected unordered list marker *, expected -


[warning] 32-32: Unexpected unordered list marker *, expected -


[warning] 33-33: Unexpected unordered list marker *, expected -


[warning] 34-34: Unexpected unordered list marker *, expected -


[warning] 35-35: Unexpected unordered list marker *, expected -


[warning] 43-43: Unexpected unordered list marker *, expected -


[warning] 44-44: Unexpected unordered list marker *, expected -


[warning] 45-45: Unexpected unordered list marker *, expected -


[warning] 46-46: Unexpected unordered list marker *, expected -


[warning] 47-47: Unexpected unordered list marker *, expected -

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/bosch_alarm.markdown (1)

9-9: Verify the release version.

The release version 2025.2.3 seems to be set far in the future. Please verify if this is the intended version number or if it should be adjusted to match the actual planned release version.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
source/_integrations/bosch_alarm.markdown (3)

25-25: Improve sentence conciseness.

The introduction can be more concise.

-The **Bosch Alarm Panel** {% term integration %} allows you to connect your [Bosch Alarm Panel](https://www.boschsecurity.com) to Home Assistant in order to control and monitor your Bosch Alarm Panel.
+The **Bosch Alarm Panel** {% term integration %} allows you to connect your [Bosch Alarm Panel](https://www.boschsecurity.com) to Home Assistant to control and monitor your Bosch Alarm Panel.
🧰 Tools
🪛 LanguageTool

[style] ~25-~25: Consider a shorter alternative to avoid wordiness.
Context: ...ww.boschsecurity.com) to Home Assistant in order to control and monitor your Bosch Alarm Pa...

(IN_ORDER_TO_PREMIUM)


52-52: Add missing period after "etc".

In American English, abbreviations like "etc." require a period.

-This entity reports state (_disarmed_, _armed_away_, etc), and contains custom attributes _ready_to_arm_ (_no_|_home_|_away_), and a _faulted_points_ counter.
+This entity reports state (_disarmed_, _armed_away_, etc.), and contains custom attributes _ready_to_arm_ (_no_|_home_|_away_), and a _faulted_points_ counter.
🧰 Tools
🪛 LanguageTool

[style] ~52-~52: In American English, abbreviations like “etc.” require a period.
Context: ...eports state (disarmed, armed_away, etc), and contains custom attributes _ready...

(ETC_PERIOD)


95-95: Remove unnecessary hyphen.

Remove the hyphen after the adverb ending in 'ly'.

-Since the _Mode 2_ automation user has "superuser" privileges, it bypasses the regularly-configured alarm pin: you will _not_ be prompted for a _User_ code when arming/disaming through the integration.
+Since the _Mode 2_ automation user has "superuser" privileges, it bypasses the regularly configured alarm pin: you will _not_ be prompted for a _User_ code when arming/disaming through the integration.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~95-~95: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ..."superuser" privileges, it bypasses the regularly-configured alarm pin: you will not be prompted f...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bae712c and 7ff0690.

📒 Files selected for processing (1)
  • source/_integrations/bosch_alarm.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/bosch_alarm.markdown

[style] ~25-~25: Consider a shorter alternative to avoid wordiness.
Context: ...ww.boschsecurity.com) to Home Assistant in order to control and monitor your Bosch Alarm Pa...

(IN_ORDER_TO_PREMIUM)


[style] ~52-~52: In American English, abbreviations like “etc.” require a period.
Context: ...eports state (disarmed, armed_away, etc), and contains custom attributes _ready...

(ETC_PERIOD)


[uncategorized] ~95-~95: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ..."superuser" privileges, it bypasses the regularly-configured alarm pin: you will not be prompted f...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@sanjay900 sanjay900 marked this pull request as ready for review February 14, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant