Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "Increase generic entity row touch target (2) #23973

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix for "Increase generic entity row touch target (2) #23973

merged 2 commits into from
Jan 31, 2025

Conversation

ildar170975
Copy link
Contributor

Reverts #23953
Causes a glitch in case of a presence of secondary-info.
Will think about an alternative solution.

@ildar170975 ildar170975 mentioned this pull request Jan 30, 2025
Closed
4 tasks
@ildar170975 ildar170975 marked this pull request as ready for review January 30, 2025 20:47
@ildar170975
Copy link
Contributor Author

Better to have #23948 instead of #23971

@ildar170975 ildar170975 marked this pull request as draft January 30, 2025 21:19
@ildar170975
Copy link
Contributor Author

ildar170975 commented Jan 30, 2025 •
edited
Loading

Alternative solution:
instead of reverting - set "line-height" conditionally.
Touch areas are colored:
523a161dba2a9d93df1ce5d0823c01d929407055

@ildar170975 ildar170975 marked this pull request as ready for review January 30, 2025 21:31
@ildar170975 ildar170975 changed the title Revert "Fix for "Increase generic entity row touch target"" Fix for "Increase generic entity row touch target (2) Jan 30, 2025
@MindFreeze MindFreeze merged commit 0aea614 into home-assistant:dev Jan 31, 2025
15 checks passed
@MindFreeze MindFreeze added this to the 2025.2 milestone Jan 31, 2025
bramkragten pushed a commit that referenced this pull request Jan 31, 2025
@ildar170975 @bramkragten
Fix for "Increase generic entity row touch target (2) (#23973)
cae1ca5 
* Revert "Fix for "Increase generic entity row touch target" (#23953)"

This reverts commit 028472f.

* conditional style
@ildar170975 ildar170975 deleted the revert-23953-fix-enlarged-row branch January 31, 2025 17:38
@mwhdc
Copy link

mwhdc commented Jan 31, 2025

Thanks for the quick fix for secondary-info spacing in 2.0b3. There is still an edge case in b3 with climate entities where multi-line state spacing is expanded as in the attached photo.

b3

@ildar170975
Copy link
Contributor Author

I see, a fix is coming.

@ildar170975 ildar170975 mentioned this pull request Jan 31, 2025
Merged
9 tasks
@ildar170975
Copy link
Contributor Author

Hopefully will be fixed by #24002

@ildar170975 ildar170975 mentioned this pull request Feb 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MindFreeze MindFreeze MindFreeze approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ildar170975 @mwhdc @MindFreeze @bramkragten