Update hdate dependency to 1.0.3 #137247
Draft
Update hdate dependency to 1.0.3 #137247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
tsvi
force-pushed
the
update-jcal
branch
2 times, most recently
from
d565704 to
0013d1c
Compare
tsvi
changed the title
zweckj
requested changes
Feb 17, 2025
| @@ -87,6 +87,7 @@ class JewishCalendarConfigFlow(ConfigFlow, domain=DOMAIN): | |||
| """Handle a config flow for Jewish calendar.""" | |||
|
|
|||
| VERSION = 1 | |||
| MINOR_VERSION = 1 | |||
There was a problem hiding this comment.
what's this change for? 1 is the default, so this doesn't change anything
There was a problem hiding this comment.
I though default would be 0. Changed to 2.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
8 tasks
|
@zweckj mind re-reviewing? |
zweckj
requested changes
Feb 21, 2025
Comment on lines
+123
to
+125
| if config_entry.version > 1: | ||
| # This means the user has downgraded from a future version | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if config_entry.version > 1: | |
| # This means the user has downgraded from a future version | |
| return False | |
| if config_entry.version > 1 or config_entry.minor_version > 1: | |
| # This means the user has downgraded from a future version | |
| return False |
Comment on lines
+127
to
+129
| if config_entry.version == 1: | ||
| if config_entry.minor_version > 1: | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if config_entry.version == 1: | |
| if config_entry.minor_version > 1: | |
| return False |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
py-libhdate/py-libhdate@v0.11.1...v1.0.3
Holiday sensor:
The above might break an automation that looks at the value of the holiday state, for one of these days.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: