-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons for custom component InelsForHass over xml-rpc #6425
base: master
Are you sure you want to change the base?
Icons for custom component InelsForHass over xml-rpc #6425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @jhoralek 👋
Thanks for opening a pull request. It looks like these are modified logos, as I couldn't find any reference/occurance of iNels using XML-RPC in their branding. Is that correct?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @frenck, you are correct. These are modified logos of iNels. This project is based on xml-rpc protocol. The InelsForHass project is my attempt to make the iNels proprietary solution available. They have been trying to create a core integration for some time, which I helped them with in the beginning. That's why I modified it so that it could somehow not damage their copyright. Kind regards JH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @jhoralek 👋
Unfortunately, I cannot accept modified branding, as they often violate with upstream branding guidelines. Please use the original and correct branding instead.
Thanks! 👍
../Frenck
Proposed change
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)[email protected]
)logo.png
)[email protected]
)