-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加展示数据库和用户信息 #1398
base: master
Are you sure you want to change the base?
增加展示数据库和用户信息 #1398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 76.84% 76.73% -0.12%
==========================================
Files 91 91
Lines 14309 14334 +25
==========================================
+ Hits 10996 10999 +3
- Misses 3313 3335 +22
Continue to review full report at Codecov.
|
第一个看了半天才明白
|
sql/instance_account.py
Outdated
@@ -19,6 +19,12 @@ def users(request): | |||
instance_id = request.POST.get('instance_id') | |||
saved = True if request.POST.get('saved') == 'true' else False # 平台是否保存 | |||
|
|||
if request.POST.get('saved') == 'True' : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接在下面过滤的地方判断 字符串 false、true 和空串会更简洁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接在下面过滤的地方判断 字符串 false、true 和空串会更简洁
这个地方我改好了
|
请教一下,这个单独的接口是指如 |
额,有冲突,晚点看看 |
@hhyo 这个要不然合并进去? |
敏感的操作,查看密码这种往可以审计日志表记录一条数据 数据库是否使用,这个个人觉得不是很有必要,建议暂时剔除 |
行,我有空搞下 |
1、增加未录入的数据库和账号
数据库和数据库账号比较多的情况下,想查看哪些数据库没有录入比较麻烦
2、增加数据库在用状态
对于已录入的数据库,数据库如果不在使用了,可以在页面上修改数据库状态为停用
需要修改表结构
3、增加数据库账号密码查看功能
不在维护如“confluence”中记录的密码
这个问题不晓得要不要单独做个权限控制?