Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to ubuntu-22.04 for releases #12464

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Jan 9, 2025

See #12411

@kirawi kirawi added the A-packaging Area: Packaging and bundling label Jan 9, 2025
@janos-r janos-r mentioned this pull request Jan 10, 2025
@janos-r
Copy link
Contributor

janos-r commented Jan 11, 2025

This is an important PR! Going even lower than 22.04 might be a good idea for the release build. As long as rustc is up to date and the Appimage process works, it is good to have a low libc version for compatibility.
I will be waiting for this to be merged to have my PR (generating a .deb file during release) working as well.

@kirawi
Copy link
Member Author

kirawi commented Jan 11, 2025

actions/runner-images#11101 We can't pin any lower, unfortunately.

@debajyoti1990
Copy link

debajyoti1990 commented Jan 11, 2025

actions/runner-images#11101 We can't pin any lower, unfortunately.

So Debian 12 or lower users wouldn't have any way to run the latest Helix release other than Homebrew. Do we?

@janos-r
Copy link
Contributor

janos-r commented Jan 11, 2025

So Debian 12 or lower users wouldn't have any way to run Helix other than Homebrew. Do we ?

After they downgrade the CI builder to 22.04, both the Appimage and my .deb should be available from releases and running on Debian 12. The .deb will have a libc6 (>= 2.34) dependency and will therefore not work on lower than Debian 12.
Unless we are allowed to make more changes to the CI run.
We could have a 22.04 image build the AppImage, and for example 20.04 build the binary and .deb, having them available on more systems. But that would be a proposal for the future. For now, lets merge this pin of all the images to 22.04.

@janos-r
Copy link
Contributor

janos-r commented Jan 11, 2025

So Debian 12 or lower users wouldn't have any way to run the latest Helix release other than Homebrew. Do we?

Or you can always use my deb build suggestion -> #12453 (comment)
Even if the system is very old, because you just compiled it yourself. But the deb installs all relevant files and can be distributed as a single file.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
kirawi and others added 2 commits January 11, 2025 10:05
@the-mikedavis the-mikedavis merged commit e440e54 into helix-editor:master Jan 11, 2025
12 of 13 checks passed
@kirawi kirawi deleted the patch-1 branch January 11, 2025 17:32
@jerabaul29
Copy link
Contributor

jerabaul29 commented Jan 14, 2025

Curious: have you "re-released" the 25.01 release applying this, so e.g. the appimage from 25.01 can work on Ubuntu 22.04? :) Seems not from the timestamp on the release files? If not, is this something you would be ok doing? (I know several people who came back to me saying the 25.01 was not working and this was the cause) :)

@the-mikedavis
Copy link
Member

After another bug fix or two we're planning on cutting a 25.01.1 patch release that will include this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants