-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin to ubuntu-22.04
for releases
#12464
Conversation
This is an important PR! Going even lower than 22.04 might be a good idea for the release build. As long as rustc is up to date and the Appimage process works, it is good to have a low libc version for compatibility. |
actions/runner-images#11101 We can't pin any lower, unfortunately. |
So Debian 12 or lower users wouldn't have any way to run the latest Helix release other than Homebrew. Do we? |
After they downgrade the CI builder to 22.04, both the Appimage and my .deb should be available from releases and running on Debian 12. The .deb will have a libc6 (>= 2.34) dependency and will therefore not work on lower than Debian 12. |
Or you can always use my deb build suggestion -> #12453 (comment) |
Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: Michael Davis <[email protected]>
Curious: have you "re-released" the 25.01 release applying this, so e.g. the appimage from 25.01 can work on Ubuntu 22.04? :) Seems not from the timestamp on the release files? If not, is this something you would be ok doing? (I know several people who came back to me saying the 25.01 was not working and this was the cause) :) |
After another bug fix or two we're planning on cutting a 25.01.1 patch release that will include this |
See #12411