make imenu-sort-function as local variable in terraform-mode #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuco1
requested changes
Aug 22, 2023
terraform-mode.el
Outdated
Comment on lines
357
to
358
| (make-local-variable 'imenu-sort-function) | ||
| (setq imenu-sort-function 'imenu--sort-by-name) |
There was a problem hiding this comment.
With buffer local variables it's better to use the idiom
(set (make-local-variable 'VARIABLE) VALUE-EXP)
for setting the value in the init.
kgrotel
approved these changes
Aug 30, 2023
kgrotel
approved these changes
Aug 30, 2023
|
Is this PR still valid? @Fuco1 can you review your changes requested or should we dismiss your requested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
imenu-sort-functionis not a buffer-local variable, we need to explicitly make it local.