test(maitake-sync): test futures impl Future
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dRawMutex` This commit fixes the trait bounds on the `mutex::Lock` type's `Future` implementation so that it's present when used with an overridden `ScopedRawMutex`, as well as the default `DefaultMutex`. Thanks to @peterkrull for reporting this issue in [this comment][1]! As noted in #516, I've also added tests for this, which wouldn't have compiled prior to this change. [1]: #515 (comment)
|
Oh, ugh, some of these tests don't actually work, as they use APIs where creating the future actually does attempt to lock immediately. I'll rework it to be based on the types instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #517
As described in #516, this commit adds tests ensuring that
Futureimpls are always present for sync primitive future types when using user-providedScopedRawMutex/RawMuteximpls. This should help protect against future regressions.Fixes #516