Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asciinema for tui demo #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use asciinema for tui demo #5

wants to merge 3 commits into from

Conversation

dfordivam
Copy link
Contributor

This replaces the ghcup.gif with a demo using latest ghcup and asciinema player.

The demo is short and similar to the ghcup.gif. It can be viewed here https://asciinema.org/a/3NMIZgpSO2Ml8CiQc6Bj3gnAW

The main page looks like this

image

@hasufell
Copy link
Member

The double checkmark looks borked for me:

Screenshot_2025-01-20_15-05-57

@dfordivam
Copy link
Contributor Author

This is a font size issue, it happens for me also on chromium. Firefox works fine.
Let me see if an override to font-family could fix this

@hasufell
Copy link
Member

Is there a reason we use asciinema directly and don't convert to a gif via https://github.com/asciinema/agg ?

@dfordivam
Copy link
Contributor Author

I had in mind adding multiple demos, so using web player would result in lower payload sizes

@hasufell
Copy link
Member

I had in mind adding multiple demos, so using web player would result in lower payload sizes

Why? Can't we just link them?

@dfordivam
Copy link
Contributor Author

You mean upload the various demos on a separate page and link them from main page.
That would be fine, and gifs would work for that.

Adding multiple gifs on the main page was my concern.

@hasufell
Copy link
Member

You mean upload the various demos on a separate page

I mean https://asciinema.org

@dfordivam
Copy link
Contributor Author

The double checkmark issue happens on asciinema.org as well. And it may be better to host various demos together in a single page, such that user can scroll and see various features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants