Add support for vertical VAT calculation #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAT may be calculated horizontally or vertically. The current implementation can only produce schema compliant Factur-X XML when the tax amount is calculated horizontally (calculating the tax amount for each line item and then adding up these values). At least in Germany it is also legal to add up the net amounts of all items within the same tax rate and then applying the tax percentage only once on that.
The Factur-X schema's business rules require
TaxTotalAmount
andCalculatedAmount
withinApplicableTradeTax
to be equal. There are inevitable rounding differences possible between the two, so the tax handling must take this into account.I used https://github.com/ZUGFeRD/mustangproject to verify my changes yield a valid Factur-X XML.
I also added an
:UNKNOWN
constant because code that has to generate a Factur-X may not know for sure which variant was used and luckily it can be inferred. I plan to work on that but for know want to finish my project but still wanted to let potential users know about this detail.