Take tax_category from Line Items and Fix validation: rounding for subcent amounts #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now taking the tax_category, which is set per tax rate, from the line_items.
This is needed because different taxes can be on one invoice, and they aren't all guaranteed to be of the same category
(see #16)
See also my comment from there:
I kept that part in place because I wanted to change as little as possible, but in theory I could also do that.
Also changing the rounding in the validation in two places:
the resulting invoice passes schematron and various online zugferd checkers.
fix #13
fix #16