Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: add pkgconfig rule #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions HaikuPorter/Policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,21 @@ def _checkProvides(self):
self._violation('no matching provides "%s" for "%s"'
% (name, 'develop/lib/' + entry))

# pkgconfig entries in develop/lib[<arch>]/pkgconfig must be declared as
# pc:*[_<arch>]
developLibPkgconfigDir = developLibDir + '/pkgconfig'
if os.path.exists(developLibPkgconfigDir):
for entry in os.listdir(developLibPkgconfigDir):
suffixIndex = entry.find('.pc')
if suffixIndex < 0:
continue

name = self._normalizeResolvableName(
'pc:' + entry[:suffixIndex] + self.secondaryArchSuffix)
if name.lower() not in self.provides:
self._violation('no matching provides "%s" for "%s"'
% (name, 'develop/lib' + self.secondaryArchSuffix + '/pkgconfig/' + entry))

def _normalizeResolvableName(self, name):
# make name a valid resolvable name by replacing '-' with '_'
return name.replace('-', '_').lower()
Expand Down
Loading