-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: add new Dial/ServerOptions to set the size like the existing ones, but which do not also disable BDP esimation #7989
base: master
Are you sure you want to change the base?
Conversation
@janardhanvissa could you add more details why is it partially addressing the issue? |
As per the proposal by Doug, the changes to the existing WithInitialWindowSize and InitialWindowSize options should be delayed for two releases. This delay ensures backward compatibility and gives users adequate time to adjust to the changes. |
@dfawley in the issue its mentioned that new options "Add new Dial/ServerOptions to set the size like the existing ones, but which do not also disable BDP esimation". What are the existing options? How do they disable bdp estimation currently? |
They are mentioned briefly in the proposal in the second comment:
How do they disable it? By passing configuration that the transport sees and disables BDP estimation. E.g. for the client: grpc-go/internal/transport/http2_client.go Line 315 in 67bee55
This PR, as-is, will not have any actual effect, so it needs work to pass these settings to the transport and make the transport use them correctly. |
bd94af4
to
15de625
Compare
Partially addresses: #7923
RELEASE NOTES: