Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semantic nullability proposal with single GraphQLSemanticNullable wrapper type #4338

Draft
wants to merge 36 commits into
base: 16.x.x
Choose a base branch
from
Draft

semantic nullability proposal with single GraphQLSemanticNullable wrapper type #4338

wants to merge 36 commits into from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Feb 2, 2025 •
edited
Loading

This is the PR I raised against #4271 back in November rebased on v16.10.0 demonstrating a version of semantic nullability demonstrating how we didn't need new both SemanticNonNull and SemanticNullable wrapping types

benjie and others added 30 commits February 2, 2025 15:14
@benjie @yaacovCR
New GraphQLSemanticNonNull type
fb9bd1f
@benjie @yaacovCR
Handle isNonNullType
0c64761
@benjie @yaacovCR
More fixes
934c634
@benjie @yaacovCR
More fixes
48c7b53
@benjie @yaacovCR
Yet more updates
b758b67
@benjie @yaacovCR
Recognize in introspection, enable disabling null bubbling
e309ed5
@benjie @yaacovCR
Lint fixes
f599c4e
@benjie @yaacovCR
More missing pieces
b7e2c7f
@benjie @yaacovCR
More fixes
033e917
@benjie @yaacovCR
Fix schema
2787de0
@benjie @yaacovCR
Fix another test
e029b6d
@benjie @yaacovCR
More minor test fixes
f69db21
@benjie @yaacovCR
Fix introspection test
e73c4ba
@benjie @yaacovCR
Add support for * to lexer
8cc7fab
@benjie @yaacovCR
Allow specifying errorPropagation at top level
6b0611d
@benjie @yaacovCR
Factor into getIntrospectionQuery
dd60b9e
@benjie @yaacovCR
Lint
3e01bb2
@benjie @yaacovCR
Prettier
0df7bdc
@twof @yaacovCR
parser tests passing
36b3cf2
@twof @yaacovCR
Add semantic optional type
69739eb
@twof @yaacovCR
printer and parser tests passing
4dcf01c
@twof @yaacovCR
some new semanticNullability execution tests
509d0c6
@twof @yaacovCR
SemanticNonNull halts null propagation
71e4057
@twof @yaacovCR
SemanticOptional cleared
5cdbf81
@twof @yaacovCR
logging cleanup
3099d63
@twof @yaacovCR
rename to SemanticNullable
9e4bf7d
@twof @yaacovCR
better SemanticNullable docs
7002eb1
@twof @yaacovCR
move semantic nullability tests to their own file
6a63f91
@twof @yaacovCR
fix git status
3d7cd06
@twof @yaacovCR
run prettier
9247ff2
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR mentioned this pull request Feb 2, 2025
Open
@yaacovCR yaacovCR changed the title null-only semantic nullability wrapper alternative semantic nullability proposal with single GraphQLSemanticNullable wrapper type Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaacovCR @benjie @twof