chore!: upgrade to Node 18 #353
Merged
+146
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sofisl
commented
Feb 12, 2025
•
sofisl
commented
- runs https://paste.googleplex.com/5722106875871232
- updates all dependencies to their latest version if compatible
- updates CI/CD and Kokoro to use Node 18
- runs lint
- updates post-processor version to latest
- removes outdated Kokoro folders
- upgrades node-fetch to v3
- drops UUID
|
Warning: This pull request is touching the following templated files:
|
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
d-goog
reviewed
Feb 13, 2025
package.json
Outdated
| @@ -40,27 +40,27 @@ | |||
| "dependencies": { | |||
| "http-proxy-agent": "^5.0.0", | |||
| "https-proxy-agent": "^5.0.0", | |||
| "node-fetch": "^2.6.9", | |||
| "node-fetch": "^2.7.0", | |||
There was a problem hiding this comment.
We will need this bumped to v3 in order to avoid punycode warnings in Node v22. Here are a few examples:
- DeprecationWarning: The
punycodemodule is deprecated. Please use a userland alternative instead google-auth-library-nodejs#1829 - punycode deprecation warning gaxios#640
Here’s an example migration:
package.json
Outdated
| "stream-events": "^1.0.5", | ||
| "uuid": "^9.0.0" | ||
| "uuid": "^11.0.5" |
There was a problem hiding this comment.
UUID is globally available as of Node 18+. Here’s how we can drop this dependency:
product-auto-label
bot
added
size: m
|
@d-goog thank you for the review and pointers! TBH, I had tried to upgrade to node-fetch v3 but couldn't figure it out. Thanks for the pointers! |
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.