Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #1255

Merged
merged 3 commits into from
Jan 2, 2024
Merged

chore: Replace deprecated command with environment file #1255

merged 3 commits into from
Jan 2, 2024

Conversation

jongwooo
Copy link
Contributor

Description

Closes #1254

Update .github/workflows/release.yaml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo ::set-output name=raw_version::"${TAG_NAME#v}"

TO-BE

run: echo "raw_version=${TAG_NAME#v}" >> $GITHUB_OUTPUT
shell: bash # for windows

@jongwooo jongwooo requested a review from a team as a code owner September 14, 2023 15:30
@noahdietz
Copy link
Collaborator

Cheers, thanks @jongwooo

@noahdietz noahdietz added automerge Summon MOG for automerging automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge Summon MOG for automerging labels Sep 14, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Sep 15, 2023
@noahdietz noahdietz added the automerge Summon MOG for automerging label Sep 20, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Sep 21, 2023
@andrei-scripniciuc andrei-scripniciuc enabled auto-merge (squash) January 2, 2024 22:39
@andrei-scripniciuc andrei-scripniciuc merged commit bb30313 into googleapis:main Jan 2, 2024
6 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch January 3, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants