Add empty ValidMode and Prepare
#725
Conversation
|
Not sure how this PR leads to "thread |
| refs: &'a mut [bool], | ||
| num_global_imports: usize, | ||
| } | ||
|
|
||
| impl<'a, 'm> ParseData<'a, 'm> { | ||
| fn new(context: &'a mut Context<'m>, refs: &'a mut [bool], num_global_imports: usize) -> Self { | ||
| impl<'a, 'm, M: ValidMode> ParseData<'a, 'm, M> { |
There was a problem hiding this comment.
Rust design question: Is there a good reason why the <'a, 'm, M> after ParseData couldn't be omitted? It seems redundant to write them since they could be inferred from the impl<'a, 'm, M: ValidMode>.
There was a problem hiding this comment.
It's because those are different things. ParseData can take arbitrary parameters. If there would be a syntactic sugar it would be the opposite. You have to specify the ParseData parameters, and any free variable would be universally quantified on the impl. But I'm not sure this would help readability.
There was a problem hiding this comment.
Could you give an example where the struct has more parameters than impl? Thanks.
There was a problem hiding this comment.
Here's an example from the standard library.
There was a problem hiding this comment.
Thanks! "universally quantified on the impl" is a very good description.
| refs: &'a mut [bool], | ||
| num_global_imports: usize, | ||
| } | ||
|
|
||
| impl<'a, 'm> ParseData<'a, 'm> { | ||
| fn new(context: &'a mut Context<'m>, refs: &'a mut [bool], num_global_imports: usize) -> Self { | ||
| impl<'a, 'm, M: ValidMode> ParseData<'a, 'm, M> { |
There was a problem hiding this comment.
It's because those are different things. ParseData can take arbitrary parameters. If there would be a syntactic sugar it would be the opposite. You have to specify the ParseData parameters, and any free variable would be universally quantified on the impl. But I'm not sure this would help readability.
The next step is to add
Verifywith optimizations.#46