Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return generalized side table from validation #720

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Return generalized side table from validation #720

merged 8 commits into from
Jan 15, 2025

Conversation

zhouwfang
Copy link
Member

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner January 13, 2025 04:02
ia0
ia0 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The main issue is that I don't think Expr should care about FuncMeta (type index and parser range). We should build a FuncMeta from the BranchTable returned by check_body() while validating the code section (where we are within the context of a function, so FuncMeta makes sense).

crates/interpreter/src/module.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
@zhouwfang zhouwfang requested a review from ia0 January 14, 2025 06:43
@zhouwfang zhouwfang changed the title Add type_idx and parser_range in SideTable during validation Return generalized side table from validation Jan 14, 2025
ia0
ia0 reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM except for the offset part.

crates/interpreter/src/module.rs Outdated Show resolved Hide resolved
crates/interpreter/src/module.rs Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Show resolved Hide resolved
@zhouwfang zhouwfang requested a review from ia0 January 15, 2025 02:53
@zhouwfang
Copy link
Member Author

Could you take a look at the follow-up PR? Thanks.

ia0
ia0 reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pushing a small review commit and merging.

crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
crates/interpreter/src/valid.rs Show resolved Hide resolved
@ia0 ia0 merged commit 7e5355d into google:dev/fast-interp Jan 15, 2025
20 checks passed
@ia0
Copy link
Member

ia0 commented Jan 15, 2025

I'm merging main into dev/fast-interp after this commit. So when pulling, you'll get new submodules and new rust toolchain. You just need to run git submodules update. The toolchain is automatic with rustup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0 ia0 ia0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhouwfang @ia0