New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip setting file to language service if exists and has not changed #336

Open

Matsuuu wants to merge 2 commits into google:main from Matsuuu:dont-update-files-if-not-needed

Contributor

Matsuuu commented Sep 15, 2022

A small bug that had slipped through the reviews in type language service rework.

Old implementation ran this.files.set every time a file was found, but wasn't modified. To reduce unnecessary map access, we just early return if..

A file is already in the language service host
But isn't updated.

Matsuuu added 2 commits

September 15, 2022 14:00


          Skip setting file to language service if exists and has not changed

84e1db4


          Lint & format

5c0fb31

Matsuuu mentioned this pull request

Allow diagnostic and completions in js #337

Open

Contributor Author

Matsuuu commented Sep 15, 2022

If #337 gets merged, this can be discarded since that PR also contains this fix

aomarks approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet