Generalize num_face_vertices_ type in mjCMesh object to be the type of tiny_obj_loader. Fixes #2332 #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talregev
changed the title
yuvaltassa
changed the title
|
This is a nice solution! Let's see what @quagla thinks. |
quagla
approved these changes
Feb 5, 2025
yuvaltassa
approved these changes
Feb 6, 2025
copybara-service
bot
merged commit cb1696e
into
google-deepmind:main
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize num_face_vertices_ type in mjCMesh object to be the type of tiny_obj_loader.
Fix #2332
@yuvaltassa FYI