Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global / local rope wavelength #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

copybara-service[bot]
Copy link

Global / local rope wavelength

PiperOrigin-RevId: 716703568
Copy link

google-cla bot commented Jan 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@IFaTaK
Copy link

IFaTaK commented Jan 30, 2025

Comment on frequency vs. wavelength usage

I noticed that the PR introduces a lot of mentions of frequency, but in several cases, the BASE_FREQUENCY variable is passed into functions expecting a wave_length argument. This creates an inconsistency—should we standardize on either frequency or wavelength across the codebase?

If we are moving towards "frequency," maybe function arguments and related variable names should reflect that change for clarity. Otherwise, if "wavelength" was the original intended concept, BASE_FREQUENCY, global_base_frequency, local_base_frequency, rope_base_frequency should be replaced by BASE_WAVELENGTH, global_base_wavelength, local_base_wavelength, rope_base_wavelength.

Would love to hear your thoughts on how we can make this more consistent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant