Feature: add eager playback global option #1591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgomez
changed the title
|
Preview of Global Options on test page:
Global Options are set to defaults on page load, and attached via query params, like so: |
|
Filed a Chromium bug to address the currentTime issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1317359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Feature
Add
eagerPlaybackglobal option to force_canPlayEventto be set tocanplay. Useful for when business logic dictates that immediate playback takes precedence over potential audio buffering.Additionally, using
canplayexposes what seems to be a Chromium bug when settingcurrentTimeon the node to the same value it's already set to. This bug is mitigated in this branch by wrapping thecurrentTimeupdate in a conditional. See this CodePen example for a demo (see theplay()function to adjust behavior): https://codepen.io/jbgomez/pen/jOYQeKQRelated Issues
#1072
Solution
Adding opt-in
eagerPlaybackglobal option. Feature is disabled by default.Reproduction/Testing
Can be observed by measuring "time-to-tune" between
eagerPlaybackmodes. When enabled, audio will begin playing relatively sooner. Test cases have been updated with the ability to set global options.Chromium bug was reproduced on Chrome in macOS and Windows 10, as well as Edge on Windows 10.
Breaking Changes
None.