Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template annotations in all major harbor components #2100

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nepomucen
Copy link

What does this change resolve?

  • it allows users the add annotations to each harbor's component Deployment.

Example use case:
Users of stakater/Reloader can now specify annotations to the various Harbor components, to let reloader perform a rolling upgrade on related Deployment's pods when secret specified in annotation is updated.

Testing

 helm template . --set core.annotations."secret\.reloader\.stakater\.com/reload"="custom-harbor-secret" | grep -A 9 core-dpl.yaml
# Source: harbor/templates/core/core-dpl.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-harbor-core
  namespace: "website-operator"
  annotations:
    secret.reloader.stakater.com/reload: custom-harbor-secret
  labels:
    heritage: Helm

@MinerYang
Copy link
Collaborator

Hi @nepomucen ,

Thanks for your contribution to harbor-helm!

Could you also help to update the configuration part of the README.md file? Appreciate!
https://github.com/goharbor/harbor-helm/blob/main/README.md#configuration

Signed-off-by: nepomucen <[email protected]>
Signed-off-by: nepomucen <[email protected]>
@nepomucen
Copy link
Author

Hi @MinerYang

Thanks for the code review. The documentation part is now updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants