Diacritics problem #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened a separate ticket for upgrading the library, it should be pulled from the maven repo, not inside the plugin. Other problems might be related to this: http://stackoverflow.com/questions/2489048/qr-code-encoding-and-decoding-using-zxing |
|
Sorry I didn't notice the separated ticket.. Yop, I read this on stackoverflow. Maybe it would be great if everybody could set the characters encoding which they need as a param. |
|
I tested http://localhost:8080/qrcode/qrcode/text/ěščřžý after I upgraded zxing to 3.1.0 and it seems to work ok. The characters are rendered ok when I scan the code with my phone. I will look into the details of this pull request after I have published version 0.4 of the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved diacritics problem (I am using characters like ěščřžý). Generated qr code in your version replaces these characters by question mark '?'. But I had to use also the latest stable version of zxing library (v 2.0) because diacritics problem remains in version 1.5 which is used in your plugin.