Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a .distignore file #28

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Add in a .distignore file #28

merged 1 commit into from
Feb 12, 2025

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 12, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

The Action we use to deploy to WordPress.org supports having either a .distignore file or a .gitattributes file. Right now we only have the latter and the issue here is we have a build directory that we exclude from the git repo but we want that in our final release. That isn't possible with a .gitattributes file, only with a .distignore file, so adding that here so we can push out another release with the proper build directory in place.

Steps to test the changes in this Pull Request:

n/a

Changelog entry

Fix - Ensure the final release asset includes the build directory.

@dkotter dkotter added this to the 2.9.1 milestone Feb 12, 2025
@dkotter dkotter self-assigned this Feb 12, 2025
@dkotter dkotter requested a review from jeffpaul February 12, 2025 17:50
@dkotter dkotter mentioned this pull request Feb 12, 2025
19 tasks
@dkotter dkotter merged commit cc9ba6e into develop Feb 12, 2025
3 of 4 checks passed
@dkotter dkotter deleted the fix/add-build-dir branch February 12, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants