Skip to content

Commit

Permalink
Move new-from-rev to step run
Browse files Browse the repository at this point in the history
This change moves the specification of the diff to check against to
the invocation of the command, allowing local runs to run against the
entire project.

Thanks @benwh.
  • Loading branch information
jackatbancast committed Apr 20, 2020
1 parent 74041b1 commit 4b348f6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- run:
name: Lint
command: |
${GOPATH}/bin/golangci-lint run
${GOPATH}/bin/golangci-lint run --new-from-rev=origin/master
build:
<<: *docker_golang
Expand Down
3 changes: 0 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,3 @@ issues:
# of integration: much better don't allow issues in new code.
# Default is false.
new: false

# Show only new issues created after git revision `origin/master`
new-from-rev: origin/master

0 comments on commit 4b348f6

Please sign in to comment.