Add Ruby 3.4 support #548
Add Ruby 3.4 support #548
Conversation
JoeSouthan
force-pushed
the
joesouthan-ruby-34
branch
5 times, most recently
from
a8ea9fa to
4013558
Compare
JoeSouthan
force-pushed
the
joesouthan-ruby-34
branch
from
4013558 to
c9eeeca
Compare
| - ruby-version: "3.1" | ||
| postgres-version: "14" | ||
| rails-version: "main" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "15" | ||
| rails-version: "main" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "16" | ||
| rails-version: "main" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "17" | ||
| rails-version: "main" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "14" | ||
| rails-version: "8.0" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "15" | ||
| rails-version: "8.0" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "16" | ||
| rails-version: "8.0" | ||
| - ruby-version: "3.1" | ||
| postgres-version: "17" | ||
| rails-version: "8.0" |
There was a problem hiding this comment.
Why is postgres-version being added to these if we're adding exclusions for all postgres versions for each combination of ruby & rails that's being excluded?
Does it not meaningfully behave the same as this, but with far more checks needing to be run (and being significantly harder to read)
| - ruby-version: "3.1" | |
| postgres-version: "14" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| postgres-version: "15" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| postgres-version: "16" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| postgres-version: "17" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| postgres-version: "14" | |
| rails-version: "8.0" | |
| - ruby-version: "3.1" | |
| postgres-version: "15" | |
| rails-version: "8.0" | |
| - ruby-version: "3.1" | |
| postgres-version: "16" | |
| rails-version: "8.0" | |
| - ruby-version: "3.1" | |
| postgres-version: "17" | |
| rails-version: "8.0" | |
| - ruby-version: "3.1" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| rails-version: "8.0" |
| - ruby-version: "3.1" | ||
| mysql-version: "8.0" | ||
| rails-version: "main" | ||
| - ruby-version: "3.1" | ||
| mysql-version: "8.4" | ||
| rails-version: "main" | ||
|
|
||
| - ruby-version: "3.1" | ||
| mysql-version: "8.0" | ||
| rails-version: "8.0" | ||
| - ruby-version: "3.1" | ||
| mysql-version: "8.4" | ||
| rails-version: "8.0" |
There was a problem hiding this comment.
Same as above, I don't see what the benefit is of having the mysql versions in the exclusions matrix if it's not being used to make new combinations
| - ruby-version: "3.1" | |
| mysql-version: "8.0" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| mysql-version: "8.4" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| mysql-version: "8.0" | |
| rails-version: "8.0" | |
| - ruby-version: "3.1" | |
| mysql-version: "8.4" | |
| rails-version: "8.0" | |
| - ruby-version: "3.1" | |
| rails-version: "main" | |
| - ruby-version: "3.1" | |
| rails-version: "8.0" |
| unless ENV["RAILS_VERSION"] | ||
| spec.add_dependency "rails", ">= 7.0" | ||
| end |
There was a problem hiding this comment.
I believe it's possible to use Statesman without ActiveRecord, using the Statesman::Adapters::Memory adapter, so I don't think we should be adding a runtime requirement on ActiveRecord where there wasn't one before
| unless ENV["RAILS_VERSION"] | |
| spec.add_dependency "rails", ">= 7.0" | |
| end |
| @@ -10,7 +10,19 @@ elsif ENV['RAILS_VERSION'] | |||
| gem "rails", "~> #{ENV['RAILS_VERSION']}" | |||
There was a problem hiding this comment.
Related to https://github.com/gocardless/statesman/pull/548/files#r1945092519, we should have a default version of Rails here for when RAILS_VERSION is not set, as we want to ensure there's always a Rails development dependency, but not necessarily a runtime dependency
| gem "rails", "~> #{ENV['RAILS_VERSION']}" | |
| gem "rails", "~> #{ENV['RAILS_VERSION']}" | |
| else | |
| gem "rails", ">= 7.0" |
https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/