Always zerofill serial numbers when validating Swedish IBANs #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For any account number that starts with a zero, when converted into an IBAN (without a clearing code) and attempting to validate it, we currently over-trim the leading zeroes. This leads us to incorrectly reject these IBANs. This change will only use the zero-fill flag when validating local details. Validating SWIFT details will always zero-fill before validation as the SWIFT account itself is zero-padded. It also reverts the change to clearing code 3300, after better understanding these accounts.
jcollins-gc
force-pushed
the
sweden-iban-swift-account-validation
branch
from
aa942e1 to
109d4d6
Compare
amaraliou
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any account number that starts with a zero, when converted into an IBAN (without a clearing code) and attempting to validate it, we currently over-trim the leading zeroes. This leads us to incorrectly reject these IBANs.
This change will only use the zero-fill flag when validating local details. Validating SWIFT details will always zero-fill before validation as the SWIFT account itself is zero-padded.
It also reverts the change to clearing code 3300, after better understanding these accounts.