Merge pull request #126 from gocardless/template-changes

Template changes
gocardless · Jan 10, 2024 · 101030f · 101030f
2 parents 9322ffa + 7009d86
commit 101030f
Show file tree

Hide file tree

Showing 9 changed files with 87 additions and 2 deletions.
diff --git a/lib/gocardless_pro/client.rb b/lib/gocardless_pro/client.rb
@@ -218,7 +218,7 @@ def default_options
           'User-Agent' => "#{user_agent}",
           'Content-Type' => 'application/json',
           'GoCardless-Client-Library' => 'gocardless-pro-ruby',
-          'GoCardless-Client-Version' => '2.52.0',
+          'GoCardless-Client-Version' => '2.53.0',
         },
       }
     end

diff --git a/lib/gocardless_pro/resources/mandate.rb b/lib/gocardless_pro/resources/mandate.rb
@@ -23,6 +23,7 @@ class Mandate
       attr_reader :id
       attr_reader :metadata
       attr_reader :next_possible_charge_date
+      attr_reader :next_possible_standard_ach_charge_date
       attr_reader :payments_require_approval
       attr_reader :reference
       attr_reader :scheme
@@ -42,6 +43,7 @@ def initialize(object, response = nil)
         @links = object['links']
         @metadata = object['metadata']
         @next_possible_charge_date = object['next_possible_charge_date']
+        @next_possible_standard_ach_charge_date = object['next_possible_standard_ach_charge_date']
         @payments_require_approval = object['payments_require_approval']
         @reference = object['reference']
         @scheme = object['scheme']

diff --git a/lib/gocardless_pro/resources/payment.rb b/lib/gocardless_pro/resources/payment.rb
@@ -24,6 +24,7 @@ class Payment
       attr_reader :created_at
       attr_reader :currency
       attr_reader :description
+      attr_reader :faster_ach
       attr_reader :fx
       attr_reader :id
       attr_reader :metadata
@@ -42,6 +43,7 @@ def initialize(object, response = nil)
         @created_at = object['created_at']
         @currency = object['currency']
         @description = object['description']
+        @faster_ach = object['faster_ach']
         @fx = object['fx']
         @id = object['id']
         @links = object['links']

diff --git a/lib/gocardless_pro/services/bank_details_lookups_service.rb b/lib/gocardless_pro/services/bank_details_lookups_service.rb
@@ -13,6 +13,11 @@ class BankDetailsLookupsService < BaseService
       # Performs a bank details lookup. As part of the lookup, a modulus check and
       # reachability check are performed.
       #
+      # In case an account holder name is provided (and an account number, a sort code
+      # or an iban
+      # are already present) an account holder name verification will also be
+      # performed.
+      #
       # If your request returns an [error](#api-usage-errors) or the
       # `available_debit_schemes`
       # attribute is an empty array, you will not be able to collect payments from the

diff --git a/lib/gocardless_pro/version.rb b/lib/gocardless_pro/version.rb
@@ -3,5 +3,5 @@ module GoCardlessPro
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '2.52.0'
+  VERSION = '2.53.0'
 end
diff --git a/spec/resources/mandate_spec.rb b/spec/resources/mandate_spec.rb
@@ -23,6 +23,7 @@
           'links' => 'links-input',
           'metadata' => 'metadata-input',
           'next_possible_charge_date' => 'next_possible_charge_date-input',
+          'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
           'payments_require_approval' => 'payments_require_approval-input',
           'reference' => 'reference-input',
           'scheme' => 'scheme-input',
@@ -45,6 +46,7 @@
                 'links' => 'links-input',
                 'metadata' => 'metadata-input',
                 'next_possible_charge_date' => 'next_possible_charge_date-input',
+                'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
                 'payments_require_approval' => 'payments_require_approval-input',
                 'reference' => 'reference-input',
                 'scheme' => 'scheme-input',
@@ -67,6 +69,7 @@
                   'links' => 'links-input',
                   'metadata' => 'metadata-input',
                   'next_possible_charge_date' => 'next_possible_charge_date-input',
+                  'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
                   'payments_require_approval' => 'payments_require_approval-input',
                   'reference' => 'reference-input',
                   'scheme' => 'scheme-input',
@@ -122,6 +125,7 @@
           'links' => 'links-input',
           'metadata' => 'metadata-input',
           'next_possible_charge_date' => 'next_possible_charge_date-input',
+          'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
           'payments_require_approval' => 'payments_require_approval-input',
           'reference' => 'reference-input',
           'scheme' => 'scheme-input',
@@ -167,6 +171,7 @@
                 'links' => 'links-input',
                 'metadata' => 'metadata-input',
                 'next_possible_charge_date' => 'next_possible_charge_date-input',
+                'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
                 'payments_require_approval' => 'payments_require_approval-input',
                 'reference' => 'reference-input',
                 'scheme' => 'scheme-input',
@@ -203,6 +208,7 @@
               'links' => 'links-input',
               'metadata' => 'metadata-input',
               'next_possible_charge_date' => 'next_possible_charge_date-input',
+              'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
               'payments_require_approval' => 'payments_require_approval-input',
               'reference' => 'reference-input',
               'scheme' => 'scheme-input',
@@ -237,6 +243,8 @@
 
         expect(get_list_response.records.first.next_possible_charge_date).to eq('next_possible_charge_date-input')
 
+        expect(get_list_response.records.first.next_possible_standard_ach_charge_date).to eq('next_possible_standard_ach_charge_date-input')
+
         expect(get_list_response.records.first.payments_require_approval).to eq('payments_require_approval-input')
 
         expect(get_list_response.records.first.reference).to eq('reference-input')
@@ -271,6 +279,7 @@
             'links' => 'links-input',
             'metadata' => 'metadata-input',
             'next_possible_charge_date' => 'next_possible_charge_date-input',
+            'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
             'payments_require_approval' => 'payments_require_approval-input',
             'reference' => 'reference-input',
             'scheme' => 'scheme-input',
@@ -299,6 +308,7 @@
             'links' => 'links-input',
             'metadata' => 'metadata-input',
             'next_possible_charge_date' => 'next_possible_charge_date-input',
+            'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
             'payments_require_approval' => 'payments_require_approval-input',
             'reference' => 'reference-input',
             'scheme' => 'scheme-input',
@@ -343,6 +353,7 @@
                 'links' => 'links-input',
                 'metadata' => 'metadata-input',
                 'next_possible_charge_date' => 'next_possible_charge_date-input',
+                'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
                 'payments_require_approval' => 'payments_require_approval-input',
                 'reference' => 'reference-input',
                 'scheme' => 'scheme-input',
@@ -381,6 +392,7 @@
               'links' => 'links-input',
               'metadata' => 'metadata-input',
               'next_possible_charge_date' => 'next_possible_charge_date-input',
+              'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
               'payments_require_approval' => 'payments_require_approval-input',
               'reference' => 'reference-input',
               'scheme' => 'scheme-input',
@@ -441,6 +453,7 @@
               'links' => 'links-input',
               'metadata' => 'metadata-input',
               'next_possible_charge_date' => 'next_possible_charge_date-input',
+              'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
               'payments_require_approval' => 'payments_require_approval-input',
               'reference' => 'reference-input',
               'scheme' => 'scheme-input',
@@ -479,6 +492,7 @@
             'links' => 'links-input',
             'metadata' => 'metadata-input',
             'next_possible_charge_date' => 'next_possible_charge_date-input',
+            'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
             'payments_require_approval' => 'payments_require_approval-input',
             'reference' => 'reference-input',
             'scheme' => 'scheme-input',
@@ -523,6 +537,7 @@
                 'links' => 'links-input',
                 'metadata' => 'metadata-input',
                 'next_possible_charge_date' => 'next_possible_charge_date-input',
+                'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
                 'payments_require_approval' => 'payments_require_approval-input',
                 'reference' => 'reference-input',
                 'scheme' => 'scheme-input',
@@ -556,6 +571,7 @@
             'links' => 'links-input',
             'metadata' => 'metadata-input',
             'next_possible_charge_date' => 'next_possible_charge_date-input',
+            'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
             'payments_require_approval' => 'payments_require_approval-input',
             'reference' => 'reference-input',
             'scheme' => 'scheme-input',
@@ -600,6 +616,7 @@
                 'links' => 'links-input',
                 'metadata' => 'metadata-input',
                 'next_possible_charge_date' => 'next_possible_charge_date-input',
+                'next_possible_standard_ach_charge_date' => 'next_possible_standard_ach_charge_date-input',
                 'payments_require_approval' => 'payments_require_approval-input',
                 'reference' => 'reference-input',
                 'scheme' => 'scheme-input',

diff --git a/spec/resources/payment_spec.rb b/spec/resources/payment_spec.rb
@@ -21,6 +21,7 @@
           'created_at' => 'created_at-input',
           'currency' => 'currency-input',
           'description' => 'description-input',
+          'faster_ach' => 'faster_ach-input',
           'fx' => 'fx-input',
           'id' => 'id-input',
           'links' => 'links-input',
@@ -43,6 +44,7 @@
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'description' => 'description-input',
+                'faster_ach' => 'faster_ach-input',
                 'fx' => 'fx-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
@@ -65,6 +67,7 @@
                   'created_at' => 'created_at-input',
                   'currency' => 'currency-input',
                   'description' => 'description-input',
+                  'faster_ach' => 'faster_ach-input',
                   'fx' => 'fx-input',
                   'id' => 'id-input',
                   'links' => 'links-input',
@@ -120,6 +123,7 @@
           'created_at' => 'created_at-input',
           'currency' => 'currency-input',
           'description' => 'description-input',
+          'faster_ach' => 'faster_ach-input',
           'fx' => 'fx-input',
           'id' => 'id-input',
           'links' => 'links-input',
@@ -165,6 +169,7 @@
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'description' => 'description-input',
+                'faster_ach' => 'faster_ach-input',
                 'fx' => 'fx-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
@@ -201,6 +206,7 @@
               'created_at' => 'created_at-input',
               'currency' => 'currency-input',
               'description' => 'description-input',
+              'faster_ach' => 'faster_ach-input',
               'fx' => 'fx-input',
               'id' => 'id-input',
               'links' => 'links-input',
@@ -235,6 +241,8 @@
 
         expect(get_list_response.records.first.description).to eq('description-input')
 
+        expect(get_list_response.records.first.faster_ach).to eq('faster_ach-input')
+
         expect(get_list_response.records.first.fx).to eq('fx-input')
 
         expect(get_list_response.records.first.id).to eq('id-input')
@@ -269,6 +277,7 @@
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'description' => 'description-input',
+            'faster_ach' => 'faster_ach-input',
             'fx' => 'fx-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -297,6 +306,7 @@
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'description' => 'description-input',
+            'faster_ach' => 'faster_ach-input',
             'fx' => 'fx-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -341,6 +351,7 @@
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'description' => 'description-input',
+                'faster_ach' => 'faster_ach-input',
                 'fx' => 'fx-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
@@ -379,6 +390,7 @@
               'created_at' => 'created_at-input',
               'currency' => 'currency-input',
               'description' => 'description-input',
+              'faster_ach' => 'faster_ach-input',
               'fx' => 'fx-input',
               'id' => 'id-input',
               'links' => 'links-input',
@@ -439,6 +451,7 @@
               'created_at' => 'created_at-input',
               'currency' => 'currency-input',
               'description' => 'description-input',
+              'faster_ach' => 'faster_ach-input',
               'fx' => 'fx-input',
               'id' => 'id-input',
               'links' => 'links-input',
@@ -477,6 +490,7 @@
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'description' => 'description-input',
+            'faster_ach' => 'faster_ach-input',
             'fx' => 'fx-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -521,6 +535,7 @@
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'description' => 'description-input',
+                'faster_ach' => 'faster_ach-input',
                 'fx' => 'fx-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
@@ -554,6 +569,7 @@
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'description' => 'description-input',
+            'faster_ach' => 'faster_ach-input',
             'fx' => 'fx-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -598,6 +614,7 @@
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'description' => 'description-input',
+                'faster_ach' => 'faster_ach-input',
                 'fx' => 'fx-input',
                 'id' => 'id-input',
                 'links' => 'links-input',