Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composor source field #33502

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add composor source field #33502

wants to merge 8 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 5, 2025

Fix #33066

@lunny lunny requested a review from KN4CK3R February 5, 2025 05:51
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Feb 5, 2025
@lunny lunny mentioned this pull request Feb 5, 2025
Open
@lunny lunny added this to the 1.24.0 milestone Feb 17, 2025
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 17, 2025
Zettat123
Zettat123 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@Zettat123 Zettat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2025
@lunny lunny mentioned this pull request Feb 18, 2025
Closed
wxiaoguang
wxiaoguang previously approved these changes Feb 21, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2025
@wxiaoguang wxiaoguang dismissed their stale review February 21, 2025 03:47

CI failure is still unresolved.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Add source in composer package
4 participants
@lunny @wxiaoguang @Zettat123 @GiteaBot