Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting repository should unlink all related packages #33653

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Deleting repository should unlink all related packages #33653

merged 5 commits into from
Feb 21, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 20, 2025

Fix #33634

@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Feb 20, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 20, 2025
@lunny lunny mentioned this pull request Feb 20, 2025
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2025
@wxiaoguang
Copy link
Contributor

Won't it duplicate?

image

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@lunny
Copy link
Member Author

lunny commented Feb 20, 2025

Won't it duplicate?

image

Fixed in 44aefd0

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 21, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 21, 2025 03:52
@wxiaoguang wxiaoguang merged commit f2fbb89 into go-gitea:main Feb 21, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 21, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 21, 2025
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Feb 21, 2025
@lunny @GiteaBot @wxiaoguang
Deleting repository should unlink all related packages (go-gitea#33653)
d6dd8c4 
Fix go-gitea#33634

---------

Co-authored-by: Giteabot <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Feb 21, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 21, 2025
@lunny lunny deleted the lunny/unlink_pkg_delete_repo branch February 21, 2025 08:05
lunny added a commit that referenced this pull request Feb 21, 2025
@GiteaBot @lunny @wxiaoguang
Deleting repository should unlink all related packages (#33653) (#33673)
aeeccc9 
Backport #33653 by @lunny

Fix #33634

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

What if the "linked" repository is deleted? Then the package becomes 404?
5 participants
@lunny @wxiaoguang @Zettat123 @delvh @GiteaBot