-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Pending RFC ] create Cell #1682
base: main
Are you sure you want to change the base?
Conversation
|
0c3159a
to
5edcc29
Compare
return this.#value; | ||
} | ||
|
||
set(value: Value): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth making the set a bounded func? For example:
set = (value: Value) => boolean {
This way we could pass this into templates and not need to create a func just to set the value of a cell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you mean?
it's a bug in the vm that this doesn't work:
<button {{on 'click' (fn cell.set 'hi')}}></button>
RFC: emberjs/rfcs#1071
I want to RFC Resources, but we don't really have an implemented way to have reactivity in them right now.
We have:
trackedData
in@glimmer/validator
-- this whole package should not be used by ember users tho, and most of its exports are not-RFC'd and should be considered private API@glimmer/tracking/primitives/storage
-- this would work as an implementation of "Cell", but isn't implemented yet@tracked
- requires creating class state, which many would feel is too cumbersome / verbose when for the "simple" cases, like having one valueTho, now that I've implemented this, I wonder if it can be placed in
@glimmer/tracking
, since@glimmer/validator
exports so much.