Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DefaultArtifactClient from @actions/artifact package #157

Merged
merged 2 commits into from
May 30, 2024
Merged

Using DefaultArtifactClient from @actions/artifact package #157

merged 2 commits into from
May 30, 2024

Conversation

codykhon
Copy link
Contributor

  • Using DefaultArtifactClient from @actions/artifact package
  • Removed creating client instance if gitleaksEnableUploadArtifact is set to false
  • Creating new instance of client only if gitleaksEnableUploadArtifact is set to true
  • Fixing some moderate vulnerabilities using npm audit fix

…using only if GITLEAKS_ENABLE_UPLOAD_ARTIFACT set to true

- @actions artifact requires importing DefaultArtifactClient to use client
- creating DefaultArtifactClient instance only if GITLEAKS_ENABLE_UPLOAD_ARTIFACT set to true, client does not need if env options set to false
…using only if GITLEAKS_ENABLE_UPLOAD_ARTIFACT set to true

- @actions artifact requires importing DefaultArtifactClient to use client
- creating DefaultArtifactClient instance only if GITLEAKS_ENABLE_UPLOAD_ARTIFACT set to true, client does not need if env options set to false
@codykhon codykhon mentioned this pull request May 30, 2024
@zricethezav zricethezav merged commit 44c470f into gitleaks:master May 30, 2024
0 of 2 checks passed
@lazyfrosch
Copy link

This sadly breaks support for Github Enterprise Server 😢

@zricethezav
Copy link
Collaborator

@lazyfrosch feel free to open an issue and provide some more context to help debug. Sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants