Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version in mod and workflows #109

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

hoenn
Copy link
Contributor

@hoenn hoenn commented Feb 8, 2024

Upgrades the go version we build and test with from 1.15 -> 1.22 to be able to upgrade passed stdlib vulnerabilities. Also simplifies CI by: not running lint in every test workflow, removes multiple go version testing.

@hoenn hoenn marked this pull request as ready for review February 12, 2024 14:51
@hoenn hoenn requested a review from a team February 12, 2024 14:51
Copy link

@tomthorogood tomthorogood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ndonewar
Copy link

Since we're doing upgrade work, should we upgrade to Go 1.22 now that it is released? The Go release policy states that versions are only supported "until there are two newer major releases" (e.g, 1.21 and 1.22). Also, it looks like 1.21.* included some security fixes.

@hoenn hoenn merged commit 3a9d57f into main Feb 12, 2024
3 checks passed
@hoenn hoenn deleted the hoenn/upgrade-go-versions branch February 12, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants