-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the octokit group in /extensions/ql-vscode with 3 updates #3899
Bump the octokit group in /extensions/ql-vscode with 3 updates #3899
Conversation
4baf261
to
6687eb1
Compare
I've pushed a new way to calculate the number of requests we'll be making, by looking at the The |
I've tested this locally by importing some repos from a code search and the progress bar was working correctly. |
I think this is caused by octokit/plugin-paginate-rest.js#637, which tries to correct the types for the items of a Would it make sense to raise an issue in octokit/plugin-paginate-rest.js or create a PR if it's easy to fix, instead of trying to work around it? |
I've opened octokit/plugin-paginate-rest.js#652 on the dependency to ask for advice. |
There's a new release that should include the fix: https://github.com/octokit/plugin-paginate-rest.js/releases/tag/v11.4.2. I'll try to get Dependabot to include that version in this PR, but that will also undo the changes that have been made to this PR. I think that's fine since ideally we would have made no changes. |
@dependabot recreate |
Bumps the octokit group in /extensions/ql-vscode with 3 updates: [@octokit/plugin-retry](https://github.com/octokit/plugin-retry.js), [@octokit/plugin-throttling](https://github.com/octokit/plugin-throttling.js) and [@octokit/rest](https://github.com/octokit/rest.js). Updates `@octokit/plugin-retry` from 7.1.2 to 7.1.3 - [Release notes](https://github.com/octokit/plugin-retry.js/releases) - [Commits](octokit/plugin-retry.js@v7.1.2...v7.1.3) Updates `@octokit/plugin-throttling` from 9.3.2 to 9.4.0 - [Release notes](https://github.com/octokit/plugin-throttling.js/releases) - [Commits](octokit/plugin-throttling.js@v9.3.2...v9.4.0) Updates `@octokit/rest` from 21.0.2 to 21.1.0 - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](octokit/rest.js@v21.0.2...v21.1.0) --- updated-dependencies: - dependency-name: "@octokit/plugin-retry" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: octokit - dependency-name: "@octokit/plugin-throttling" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: octokit - dependency-name: "@octokit/rest" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: octokit ... Signed-off-by: dependabot[bot] <[email protected]>
c60493d
to
0bdd4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the Code Search functionality and it still works after these updates.
Bumps the octokit group in /extensions/ql-vscode with 3 updates: @octokit/plugin-retry, @octokit/plugin-throttling and @octokit/rest.
Updates
@octokit/plugin-retry
from 7.1.2 to 7.1.3Release notes
Sourced from
@octokit/plugin-retry
's releases.Commits
b76ebd6
fix(deps): bump octokit deps to fix Deno compat (#602)1a0841a
build(deps): lock file maintenance (#603)d0d4731
build(deps): lock file maintenance (#601)1c41785
build(deps): lock file maintenance (#600)aa93a7d
build(deps): lock file maintenance (#599)79e4756
build(deps): lock file maintenance (#597)ef3c189
chore(deps): update dependency prettier to v3.4.2 (#598)05a59e4
chore(deps): update dependency prettier to v3.4.1 (#596)b4cae1f
build(deps): lock file maintenance (#594)49f794c
chore(deps): update dependency prettier to v3.4.0 (#595)Updates
@octokit/plugin-throttling
from 9.3.2 to 9.4.0Release notes
Sourced from
@octokit/plugin-throttling
's releases.Commits
2dab79a
feat: new action runner groups endpoints, new code scanning alerts autofix en...553f0b4
fix(deps): bump Octokit deps to fix Deno compat (#761)2a6e70a
build(deps): lock file maintenance (#760)1028270
build(deps): lock file maintenance (#759)e150c35
build(deps): lock file maintenance (#758)a5eabc5
chore(deps): update dependency prettier to v3.4.2 (#756)c1b2b54
build(deps): lock file maintenance (#757)c4b3e9b
build(deps): lock file maintenance (#755)a439606
chore(deps): update dependency prettier to v3.4.1 (#753)a53d18f
build(deps): lock file maintenance (#751)Updates
@octokit/rest
from 21.0.2 to 21.1.0Release notes
Sourced from
@octokit/rest
's releases.Commits
908b1c8
feat: new endpoints, bump Octokit deps to fix Deno (#477)751b522
chore(deps): update dependency fetch-mock to v12 (#470)5ad12fd
chore(deps): update dependency@types/node
to v22 (#472)c88980a
ci(action): update actions/checkout digest to 11bd719 (#469)94443df
ci(action): update actions/checkout digest to eef6144 (#467)c59fcf6
chore(deps): update dependency@octokit/tsconfig
to v4 (#464)2f97e4c
build(deps): Bump body-parser and express (#465)2dec6cc
chore(deps): update dependency esbuild to ^0.24.0 (#463)Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions