Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include README in generated rustdoc files. #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrickt
Copy link
Contributor

No description provided.

@patrickt patrickt requested a review from a team as a code owner January 28, 2024 17:05
@jorendorff
Copy link
Contributor

This puts a # Heading into the rustdoc, which is very slightly ugly -- it's fine, by all means go ahead.

An alternative way to do this is to use cargo install cargo-readme then cargo readme > README.md, plus I guess some scripting and lints to support the practice.

Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly included documentation includes some fenced code blocks that cargo test is trying to run as doc-tests. This is why the tests are failing.

You can mark those as ```ignore but then they wouldn't be highlighted anymore... maybe cargo-readme is the way to go here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants