Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #1204
Description
This PR dynamically adjusts the
chunkSize
to be based on execution time feedback. It is disabled by default for backward compatibility, but should be considered a default for future releases. As well as improving performance (my motivation) it is a little bit safer than a staticchunkSize
considering wide-tables with a lot of secondary indexes.There are also some guard rails in place to make sure if the observed execution time is 5x the target, it quickly scales down the
chunkSize
(which is not a problem, as it will later scale back up if this was a temporary blip).Here's what I observed with some sample tables:
script/cibuild
returns with no formatting errors, build errors or unit test errors.