Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for matchAll js #17910

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Support for matchAll js #17910

wants to merge 12 commits into from

Conversation

Napalys
Copy link

@Napalys Napalys commented Nov 5, 2024

Added support for ES2020 feature, matchAll.
Related issue: github/codeql-javascript-team/issues/435

@Napalys Napalys added the JS label Nov 5, 2024
erik-krogh
erik-krogh reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, otherwise LGTM assuming the evaluations look good.

I think we should also look at MembershipCandidates.qll and TaintTracking.qll.

But lets do that in a followup PR.

javascript/ql/src/Security/CWE-020/MissingRegExpAnchor.ql Outdated Show resolved Hide resolved
@Napalys Napalys force-pushed the napalys/matchAll-support branch 2 times, most recently from 9809499 to a96f9fc Compare November 7, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Napalys @erik-krogh