Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Feature.ArtifactV4Upgrade default to true #2583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 8, 2024

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows. -- This change is not backwards compatible with existing workflows (if they use the debug artifact feature which I've never seen outside of this repository)
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 8, 2024

Note: I've left a file that tests the old v3 behavior. It's clearly called legacy, and I saw no particular reason to remove it yet as I'm not removing the code that it validates and someone who has access to GHES could conceivably want to test it.

This PR gave me enough insight that I could probably write some code to let that workflow skip doing real work unless it was running under GHES, although the lazy test would be to check the server URL as I did in my initial work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant