Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for public gh app #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support for public gh app #165

wants to merge 1 commit into from

Conversation

karpikpl
Copy link
Collaborator

When NUXT_PUBLIC_IS_PUBLIC_APP is set to true, application will read GitHub app installations for logged in user and redirect to the first organization on the returned list.

@karpikpl karpikpl requested a review from Copilot February 19, 2025 07:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

server/routes/auth/github.get.ts:8

  • [nitpick] Consider using a proper logging library instead of console for logging.
const logger = console;

server/routes/auth/github.get.ts:43

  • [nitpick] The error message 'No organizations found for the user.' could be more descriptive.
console.error('No organizations found for the user.');

server/routes/auth/github.get.ts:49

  • The error should be cast to FetchError to ensure proper type handling.
catch (error: FetchError) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant