Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #142 GitHub custom scopes #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

karpikpl
Copy link
Collaborator

Supporting custom scopes for GitHub

Signed-off-by: Piotr Karpala <[email protected]>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

server/routes/auth/github.get.ts:4

  • [nitpick] Consider trimming whitespace from the resulting scope strings after splitting to ensure they match the expected values for GitHub's OAuth scopes.
scope: process.env.NUXT_OAUTH_GITHUB_CLIENT_SCOPE ? process.env.NUXT_OAUTH_GITHUB_CLIENT_SCOPE.split(',') : undefined,

app/components/MainComponent.vue:152

  • [nitpick] The updated error message now uses double quotes for organization details; ensure that this change aligns with the overall string formatting guidelines applied across the project for consistency.
apiError.value = `404 Not Found - is the ${config.public.scope || ''} org:"${config.public.githubOrg || ''}" ent:"${config.public.githubEnt || ''}" team:"${config.public.githubTeam}" correct? ${error.message}`;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Standalone integration with GitHub App not working
1 participant