Adding Seats with No Activity in 30 days in Seat Analysis #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Seats with No Activity in 30 days
fixing bug related to 30 days
daniel-citation
approved these changes
Oct 10, 2024
karpikpl
requested changes
Oct 22, 2024
| @@ -116,27 +128,39 @@ data() { | |||
| setup(props) { | |||
| let totalSeats = ref<Seat[]>([]); | |||
| let NoshowSeats = ref<Seat[]>([]); | |||
| const unusedSeats = ref<Seat[]>([]); | |||
| const unusedSeatsInSevenDays = ref<Seat[]>([]); | |||
There was a problem hiding this comment.
do we need ref of <Seat[]> if only length is used?
|
|
||
| NoshowSeats.value = props.seats.filter(seat => seat.last_activity_at == null); | ||
|
|
||
| unusedSeats.value = totalSeats.value.filter(seat => { | ||
| unusedSeatsInSevenDays.value = totalSeats.value.filter(seat => { |
There was a problem hiding this comment.
this could be slightly improved if there's just one loop and we check activity date and add to counter, instead of going through all the seats twice
|
thanks for the PR, let me know if you have time to make suggested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Seats with No Activity in 30 days in Seat Analysis