Fix default values in vlab gen help #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #294 Signed-off-by: Pau Capdevila <[email protected]>
|
@pau-hedgehog hi, there were no defaults by design - it's handled in the gen code, which is a bad approach and need complete rework. Your change currently breaks intended CI setup as it's not setting values explicitly. Let me see what we can do to make it work |
|
Shall we close this one? Or what do you suggest we do, @Frostman ? |
|
I think let's close it and get back it little later with the rework of the wiring gen, it'll be somewhat related to GW work as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294